fix(bulkWrite): pass overwriteImmutable option to castUpdate fixes #15789
+47
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #15781 by ensuring the overwriteImmutable option is properly propagated from bulkWrite operations through the casting pipeline to the handleImmutable function. This allows users to explicitly override immutable field protection when using bulkWrite operations, which was previously not possible.
Key Changes:
- Modified
handleImmutableto accept and respect theoverwriteImmutableoption - Updated
castUpdateto pass options through tohandleImmutablecalls - Modified
castBulkWriteto passoverwriteImmutablefrom operation options tocastUpdatefor both updateOne and updateMany operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/model.updateOne.test.js | Adds test case verifying that overwriteImmutable: true allows updating immutable createdAt field via bulkWrite |
| lib/helpers/query/handleImmutable.js | Adds options parameter to function signature and checks for options.overwriteImmutable to bypass immutable protection |
| lib/helpers/query/castUpdate.js | Updates both handleImmutable call sites to pass the options parameter |
| lib/helpers/model/castBulkWrite.js | Passes overwriteImmutable option from bulkWrite operations to castUpdate for updateOne and updateMany; also passes timestamps option to applyTimestampsToUpdate for granular timestamp control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Tysm! |
hasezoey
approved these changes
Nov 26, 2025
AbdelrahmanHafez
approved these changes
Nov 27, 2025
AbdelrahmanHafez
approved these changes
Nov 28, 2025
AbdelrahmanHafez
requested changes
Nov 28, 2025
Collaborator
AbdelrahmanHafez
left a comment
AbdelrahmanHafez
left a comment
There was a problem hiding this comment.
I noticed that we can't use overwriteImmutable in TypeScript, pushing a fix for 7.x and master as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15781
Backport #15782 to 7.x
Summary
Examples